AccountStatusUserDetailsChecker implements MessageSourceAware#6151
Merged
rwinch merged 1 commit intospring-projects:masterfrom May 1, 2019
Merged
AccountStatusUserDetailsChecker implements MessageSourceAware#6151rwinch merged 1 commit intospring-projects:masterfrom
rwinch merged 1 commit intospring-projects:masterfrom
Conversation
|
@weebl2000 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@weebl2000 Thank you for signing the Contributor License Agreement! |
rwinch
requested changes
Nov 30, 2018
Member
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the PR! I provided feedback inline
...c/main/java/org/springframework/security/authentication/AccountStatusUserDetailsChecker.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/authentication/AccountStatusUserDetailsChecker.java
Outdated
Show resolved
Hide resolved
Author
|
Should be fixed |
Member
|
Thanks @weebl2000! Can you please update the commit message to align with the Spring Security conventions? It is missing |
Author
|
Amended commit message to include "Fixes: gh-3980" |
rwinch
changed the title
rwinch
added
in: core
rwinch
approved these changes
Dec 7, 2018
Member
|
Thanks for the PR @weebl2000! This is now merged into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #3980