CookieClearingLogoutHandler enhancement#6116
Merged
rwinch merged 3 commits intospring-projects:masterfrom Nov 26, 2018
Merged
Conversation
Enabled the ability to pass in an array of Cookies to support clearing cookies on a different path other than the default context path Issue: spring-projectsgh-6078
Contributor
Author
|
FYI - I wasn't sure what to put in for the |
rwinch
requested changes
Nov 21, 2018
Member
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the PR @maxcoinage! I have provided feedback inline.
| */ | ||
| public final class CookieClearingLogoutHandler implements LogoutHandler { | ||
| private final List<String> cookiesToClear; | ||
| private final List<Object> cookiesToClear; |
Member
There was a problem hiding this comment.
Let's change this to List<Function<HttpServletRequest,Cookie>>. In each of the constructors we can convert the arguments into a Function<HttpServletRequest,Cookie>.
| } | ||
|
|
||
| /** | ||
| * @since 5.X |
| response.addCookie(cookie); | ||
| for (Object cookie : cookiesToClear) { | ||
| Cookie realCookie = null; | ||
| if (cookie instanceof String) { |
Member
There was a problem hiding this comment.
This logic will obviously need updated once we change this.cookiesToClear.
Changed the implementation to use an anonymous function Issue: spring-projectsgh-6078
Contributor
Author
|
@rwinch Thanks for the feedback, I was not too happy with my initial solution and think your proposal is much better PR is now updated, please check at your convenience |
rwinch
added
in: web
rwinch
approved these changes
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabled the ability to pass in an array of Cookies to support clearing cookies on a different path other than the default context path
Issue: gh-6078
Issue #6078
cc: @rwinch