Update document regarding Stream usage#17219
Merged
jzheaux merged 2 commits intospring-projects:mainfrom Jun 20, 2025
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Jun 17, 2025
Contributor
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
Thanks, @ngocnhan-tran1996! Will you please make the language change listed and also move it to https://github.com/spring-projects/spring-security/blob/main/CONTRIBUTING.adoc#code-style
jzheaux
added
in: docs
ngocnhan-tran1996
force-pushed
the
gh-17097
branch
from
03211ca to
6c7f9d3
Compare
jzheaux
requested changes
Jun 20, 2025
Contributor
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
Thanks, @ngocnhan-tran1996. I've left my feedback inline.
| There are many ways to contribute, including answering questions on Stack Overflow, writing new code, improving existing code, assisting with documentation, developing samples or tutorials, reporting bugs, or simply making suggestions. | ||
| For more information, see our https://github.com/spring-projects/spring-security/blob/main/CONTRIBUTING.adoc[Contributing] documentation. | ||
|
|
||
| NOTE: Since the Stream API is https://github.com/spring-projects/spring-security/issues/7154[much slower] than `for` loop, please use it judiciously. |
Contributor
There was a problem hiding this comment.
Will you please remove it from this document? Since it is in the contributing guidelines already, there's no reason to duplicate.
Closes spring-projectsgh-17097 Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
jzheaux
approved these changes
Jun 20, 2025
Contributor
|
Great, @ngocnhan-tran1996! This will merge once the build passes. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-17097