Add mapping for DPoP in DefaultMapOAuth2AccessTokenResponseConverter#16806
Closed
hammadirshad wants to merge 1 commit intospring-projects:mainfrom
Closed
Add mapping for DPoP in DefaultMapOAuth2AccessTokenResponseConverter#16806hammadirshad wants to merge 1 commit intospring-projects:mainfrom
hammadirshad wants to merge 1 commit intospring-projects:mainfrom
Conversation
Contributor
|
The Spring team recently migrated to the Developer Certificate of Origin (DCO) for our contribution process. See Submitting Pull Requests for additional details on the new process. Please format the commit in this PR as the DCO check did not pass. The changes look good in the PR so we'll get this merged as soon as the DCO check passes. However, please update the copyright year in the 2 files. Thank you. |
Signed-off-by: muha <[email protected]>
Contributor
Author
|
Hi @jgrandja |
Contributor
|
Thanks for the update @hammadirshad. This is now merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing mapping for the newly introduced TokenType.DPOP in DefaultMapOAuth2AccessTokenResponseConverter. Without this mapping, deserializing an OAuth 2.0 Access Token Response containing a DPoP token type results in an error:
An error occurred reading the OAuth 2.0 Access Token Response: tokenType cannot be nullStacktrace