Support custom RequestMatcher in WebAuthn filters

[leshalv]

No description provided.

[jzheaux]

Hi, @leshalv, and thanks for this PR. I've left an inline checklist of JavaDoc polishes. Also, will you please add tests for each of these setter methods that confirm:

1. They error appropriately when null is given
2. The filter appropriately uses the provided request matcher.

Note that for the second test, the filter doesn't necessarily need to get triggered; it simply needs to be clear that the given requestMatcher was used to match the request.

[leshalv]

Is there anything else that needs to be changed now? @jzheaux

[jzheaux]

Thanks for the updates, @leshalv! Yes, please add the tests I described here: #16517 (review)

[leshalv]

@jzheaux Take a look

[jzheaux]

This is coming along, @leshalv! Thanks for the updates. I've left some additional feedback inline to further improve the tests.

[jzheaux]

Nice work, @leshalv! Note that I've rebased your branch and squashed the commits down to one.

The last thing that is needed is for you to do is correct the commit signature. It appears your git username and email don't match the signature:

Author: topiam <[email protected]>
Date:   Sat Feb 1 23:04:04 2025 +0800

...

Signed-off-by: smallbun <[email protected]>

The author and the signature need to be the same. Because you are working on main, your next pull will require a hard reset. If your fork is mapped to origin, then the command is: git fetch origin && git reset --hard origin/main

[jzheaux]

Thanks @leshalv for the PR! I squashed your commits and merged them in 85f0f3f and then added a polish to correct the failing build e569c7a

My apologies about the confusion with your main branch. In the future, this can be avoided by contributing PRs on a separate branch. I'll add a note for myself to remind folks about this when PRs are opened.