Send saml logout response even when validation errors happen#14676
Send saml logout response even when validation errors happen#14676jzheaux merged 4 commits intospring-projects:mainfrom
Conversation
|
Thanks for the PR, @1livv. This is going to take a little bit more work to maintain backward compatibility and also ensure that the APIs progress naturally. I'll get back to you soon with recommendations. |
...-service-provider/src/main/java/org/springframework/security/saml2/core/Saml2ErrorCodes.java
Outdated
Show resolved
Hide resolved
...-service-provider/src/main/java/org/springframework/security/saml2/core/Saml2ErrorCodes.java
Outdated
Show resolved
Hide resolved
...-service-provider/src/main/java/org/springframework/security/saml2/core/Saml2ErrorCodes.java
Outdated
Show resolved
Hide resolved
...work/security/saml2/provider/service/web/authentication/logout/Saml2LogoutRequestFilter.java
Show resolved
Hide resolved
...k/security/saml2/provider/service/web/authentication/logout/Saml2LogoutResponseResolver.java
Outdated
Show resolved
Hide resolved
...ngframework/security/config/annotation/web/configurers/saml2/Saml2LogoutConfigurerTests.java
Outdated
Show resolved
Hide resolved
...-service-provider/src/main/java/org/springframework/security/saml2/core/Saml2ErrorCodes.java
Outdated
Show resolved
Hide resolved
...work/security/saml2/provider/service/web/authentication/logout/Saml2LogoutRequestFilter.java
Show resolved
Hide resolved
...ngframework/security/config/annotation/web/configurers/saml2/Saml2LogoutConfigurerTests.java
Show resolved
Hide resolved
|
Hi, @1livv, are you able to make the requested changes? |
|
Hey @jzheaux this slipped off my radar, i'll take a look in the next days. |
|
@1livv I'd be willing to take care of the change requests if you are ok with this |
|
Yes, that would be great thank you @jan-knoblich !! |
|
@1livv Could you Sync your repository with the main one? Otherwise I will have to create a new one. There are some changes that impact the changes in this PR |
|
@1livv and @jan-knoblich, I've rebased the PR, thanks for your patience. Would either of you like to apply the listed changes? If I don't hear from you one way or the other by next week, I'll go ahead and provide a polish commit myself. |
Signed-off-by: Liviu Gheorghe <[email protected]>
Signed-off-by: Liviu Gheorghe <[email protected]>
Signed-off-by: Liviu Gheorghe <[email protected]>
Signed-off-by: Liviu Gheorghe <[email protected]>
|
Thanks, @1livv! This is now merged into |
solves #14635