Add DelegatingAuthenticationConverter #14655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
franticticktick
force-pushed
the
gh-14644
branch
2 times, most recently
from
4f2cf89 to
dba347c
Compare
Contributor
Author
|
@jzheaux Can you review this please? I will be very grateful. |
franticticktick
force-pushed
the
gh-14644
branch
from
dba347c to
9ea70c5
Compare
franticticktick
changed the title
jzheaux
requested changes
Mar 6, 2024
Contributor
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
Thanks, @CrazyParanoid! I've left my feedback inline.
.../java/org/springframework/security/web/authentication/DelegatingAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
.../java/org/springframework/security/web/authentication/DelegatingAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
.../java/org/springframework/security/web/authentication/DelegatingAuthenticationConverter.java
Outdated
Show resolved
Hide resolved
jzheaux
added
in: web
franticticktick
force-pushed
the
gh-14644
branch
from
9ea70c5 to
7215cd1
Compare
Contributor
Author
|
Thanks @jzheaux for feedback! All your comments have been resolved. |
franticticktick
force-pushed
the
gh-14644
branch
from
7215cd1 to
446d049
Compare
jzheaux
approved these changes
Mar 13, 2024
jzheaux
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-14644