KafkaTestUtils unified consumerPros call

[mipo256]

Currently, the KafkaTestUtils#consumerProps overloaded methods I think have a couple of problems:

1. Their arguments order is not aligned with each other:

(String group, String autoCommit, EmbeddedKafkaBroker embeddedKafka)
(String brokers, String group)
(String brokers, String group, String autoCommit)

The group goes either the first one, or the second one, the same goes for autocommit setting

2. The enable.auto.commit is a boolean according to doc, so I think accepting a String is not type safe, since the value. Making the API more typesafe I think is generally a good idea.

[artembilan]

Please, add your name to the @author list of the affected class.
Thanks

[artembilan]

Please, build the project locally and look into logs.
There are a bunch of warnings like this:

/home/runner/work/spring-kafka/spring-kafka/spring-kafka-test/src/test/java/org/springframework/kafka/test/utils/KafkaTestUtilsTests.java:58: warning: [removal] consumerProps(String,String,EmbeddedKafkaBroker) in KafkaTestUtils has been deprecated and marked for removal
		Map<String, Object> consumerProps = KafkaTestUtils.consumerProps("ktuTests1", "false", broker);

I expect that new API would be used whenever it is still rely on just deprecated one.
Thanks

[mipo256]

I agree, I'll migrate the usages fo the deprecated API. The .editorconfig commit really seems to be a bit off-topic, I'll roll it back.

[sobychacko]

I wonder whether we can make these changes in 3.3.x so that we can remove the deprecated methods from 4.0.0 altogether?

[mipo256]

That is a good point, @sobychacko, I also thought about it. I think this is open to discussion. The question is do we want to provide the extended grace period, or we do not. The KafkaTestUtil is quite heavily used, and spring-kafka 4.0 is going to be released relatively soon. So, I'll leave the resolution of this to you guys 😄.

P.S: @artembilan I have cleaned-up all the usages of the deprecated API

[artembilan]

Thank you for contribution, @mipo256 !

Please, consider to fix your Git client to add your real Mikhail Polivakha name to the signed-off-by sentence in the commit message.

[mipo256]

Sure @artembilan. Thank you!