ssl.chain.expiry metrics doesn't update for dynamically registered SSL bundles #48153
+45
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
This was referenced Nov 17, 2025
mhalbritter
added
type: bug
mhalbritter
changed the title
Signed-off-by: TerryTaoYY <[email protected]>
TerryTaoYY
force-pushed
the
fix-ssl-bundle-metrics
branch
from
029d495 to
70c4801
Compare
snicoll
pushed a commit
that referenced
this pull request
Nov 18, 2025
See gh-48153 Signed-off-by: TerryTaoYY <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
SslMeterBinderis constructed, it only registers update handlers for the bundlesreturned by
sslBundles.getBundleNames()at that time. Bundles that are registered lateronly trigger the register handler once and never get an update handler, so subsequent
SslBundleRegistry.updateBundle(...)calls do not refresh thessl.chain.expirygauges.This change updates the register handler to also register an update handler for the
newly registered bundle and adds a regression test:
SslMeterBinderTests.shouldWatchUpdatesForBundlesRegisteredAfterConstructionThe test fails with the original implementation and passes with this change.
Fixes #48144 (gh-48144)