Skip to content

Property placeholders aren't resolved when configuration property binding creates a Map from a property value using a converter #39507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wanger26 wants to merge 1 commit into from
Closed

Property placeholders aren't resolved when configuration property binding creates a Map from a property value using a converter #39507

wanger26 wants to merge 1 commit into from

Conversation

@wanger26
Copy link
Contributor

@wanger26 wanger26 commented Feb 10, 2024 •
edited
Loading

Change Summary

  • Add call to placeholder resolver to ensure property placeholders are resolved for the MapperBinder similar to Binder.java

Issue

@wanger26
FIX BUG - Resolve property placeholder when binding properties to a Map
62038d1 
Add call to placeholder resolver to ensure property placeholders are resolved for the MapperBinder similar to Binder

Signed-off-by: wanger26 <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 10, 2024
@scottfrederick scottfrederick changed the title FIX BUG - Resolve property placeholder when binding properties to a Map Property placeholders aren't resolved when configuration property binding creates a Map from a property value using a converter Feb 11, 2024
@scottfrederick scottfrederick added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 11, 2024
@scottfrederick scottfrederick added this to the 3.1.9 milestone Feb 11, 2024
This was referenced Feb 11, 2024
Closed
Closed
scottfrederick pushed a commit that referenced this pull request Feb 11, 2024
@wanger26 @scottfrederick
Resolve property placeholders when binding properties to a Map
8292104 
Add call to placeholder resolver to ensure property placeholders
are resolved for the `MapBinder`

See gh-39507

Signed-off-by: wanger26 <[email protected]>
scottfrederick added a commit that referenced this pull request Feb 11, 2024
@scottfrederick
Polish "Resolve property placeholders when binding properties to a Map"
f90f29d 
See gh-39507
@scottfrederick
Copy link
Contributor

scottfrederick commented Feb 11, 2024

Thanks again @wanger26. I've merged your changes along with a small commit to address formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type: bug A general bug

Projects

None yet

Milestone

3.1.9

Development

Successfully merging this pull request may close these issues.

3 participants

@wanger26 @scottfrederick @spring-projects-issues