HealthEndpointGroupMembershipValidator does not consider reactive health indicators causing NoSuchHealthContributorException to be thrown

[aschepp]

Spring Boot 4.0.0

I tried to add the ReactiveMongoHealthIndicator to a health group (with management.endpoint.health.group.liveness.include: mongo)

The app won't start with NoSuchHealthContributorException error.

If I set management.endpoint.health.validate-group-membership to false, the app starts, but the HealthIndicator is not part of the health group.

I then debugged the HealthEndpointGroupMembershipValidator and saw, that only non reactive HealthIndicator are included.

I was able to temporarily fix it, by defining a normal MongoHealthIndicator bean.

[philwebb]

It looks like HealthEndpointGroupMembershipValidator should also check against the reactive registry if it's available.

If I set management.endpoint.health.validate-group-membership to false, the app starts, but the HealthIndicator is not part of the health group.

Can you expand a bit on "the HealthIndicator is not part of the health group"? Do you mean it doesn't appear in the JSON response?

[aschepp]

Yes, it's not part of the response.

[philwebb]

@aschepp, I can replicate the HealthEndpointGroupMembershipValidator issue, but I'm having trouble reproducing the indicator being missing from the response.

This is my application.properties:

management.endpoint.health.group.liveness.include=mongo
management.endpoint.health.validate-group-membership=false
management.endpoints.web.exposure.include=*
management.endpoint.health.show-details=always

This is the response:

$ http http://localhost:8080/actuator/health/liveness

HTTP/1.1 200 OK
Content-Length: 125
Content-Type: application/vnd.spring-boot.actuator.v3+json

{
    "components": {
        "mongo": {
            "details": {
                "databases": [
                    "config",
                    "admin",
                    "local"
                ],
                "maxWireVersion": 27
            },
            "status": "UP"
        }
    },
    "status": "UP"
}

Do you have management.endpoint.health.show-details=always set in your code?

[philwebb]

@aschepp I think I've fixed the validation problem. Please open a new issue if you can reproduce the indicator being missing from the response (#48387 (comment)).

[aschepp]

I tried several versions, but I couldn't replicate the indicator being missing anymore. So all good from my side. Thanks for your quick response.