Fix TraceableExecutorService#1437
Merged
marcingrzejszczak merged 1 commit intospring-cloud:masterfrom Sep 5, 2019
koozz:patch-1
Merged
Fix TraceableExecutorService#1437marcingrzejszczak merged 1 commit intospring-cloud:masterfrom koozz:patch-1
marcingrzejszczak merged 1 commit intospring-cloud:masterfrom
koozz:patch-1
Conversation
TraceableExecutorService swallows Exception because `execute` submits a Runnable and ignores the Future's result. It should call the delegates `execute` method instead of the `submit`.
Codecov Report
@@ Coverage Diff @@
## master #1437 +/- ##
=========================================
Coverage 57.61% 57.61%
Complexity 796 796
=========================================
Files 150 150
Lines 4287 4287
Branches 460 460
=========================================
Hits 2470 2470
Misses 1606 1606
Partials 211 211
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1437 +/- ##
=========================================
Coverage 57.61% 57.61%
Complexity 796 796
=========================================
Files 150 150
Lines 4287 4287
Branches 460 460
=========================================
Hits 2470 2470
Misses 1606 1606
Partials 211 211
Continue to review full report at Codecov.
|
Contributor
|
😱 thanks for the great catch! |
marcingrzejszczak
pushed a commit
that referenced
this pull request
Sep 5, 2019
TraceableExecutorService swallows Exception because `execute` submits a Runnable and ignores the Future's result. It should call the delegates `execute` method instead of the `submit`.
Contributor
Author
Credit goes to: @tdons |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TraceableExecutorService swallows Exception because
executesubmits a Runnable and ignores the Future's result. It should call the delegatesexecutemethod instead of thesubmit.