Return 0 status code on exception or invalid code#1387
Merged
marcingrzejszczak merged 2 commits into2.1.xfrom Jul 3, 2019
Merged
Return 0 status code on exception or invalid code#1387marcingrzejszczak merged 2 commits into2.1.xfrom
marcingrzejszczak merged 2 commits into2.1.xfrom
Conversation
| @Override | ||
| public Integer statusCode(ClientResponse response) { | ||
| return response.statusCode().value(); | ||
| return response.rawStatusCode(); |
Contributor
There was a problem hiding this comment.
something like this otherwise you still end up with the exception :P
@Override public Integer statusCode(HttpResponse response) {
int result = statusCodeAsInt(response);
return result != 0 ? result : null;
}
Contributor
Author
There was a problem hiding this comment.
Ok but statusCode is called only via the statusCodeAsInt in Brave
Codecov Report
@@ Coverage Diff @@
## 2.1.x #1387 +/- ##
===========================================
+ Coverage 66.78% 67% +0.22%
Complexity 850 850
===========================================
Files 145 145
Lines 4028 4031 +3
Branches 422 422
===========================================
+ Hits 2690 2701 +11
+ Misses 1099 1090 -9
- Partials 239 240 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## 2.1.x #1387 +/- ##
============================================
- Coverage 66.78% 66.61% -0.17%
Complexity 850 850
============================================
Files 145 145
Lines 4028 4032 +4
Branches 422 423 +1
============================================
- Hits 2690 2686 -4
- Misses 1099 1108 +9
+ Partials 239 238 -1
Continue to review full report at Codecov.
|
codefromthecrypt
approved these changes
Jul 3, 2019
codefromthecrypt
pushed a commit
to openzipkin/brave
that referenced
this pull request
Jul 3, 2019
Eventhough new instrumentation don't use it, old could. See spring-cloud/spring-cloud-sleuth#1387
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes gh-1382