spring.zipkin.discoveryClientEnabled=false is not work #1376
Description
Bug report
@Configuration
@ConditionalOnClass(LoadBalancerClient.class)
static class DiscoveryClientZipkinUrlExtractorConfiguration {
@Configuration
@ConditionalOnProperty(value = "spring.zipkin.discoveryClientEnabled", havingValue = "true", matchIfMissing = true)
static class ZipkinClientLoadBalancedConfiguration {
@Autowired(required = false)
LoadBalancerClient client;
@Bean
@ConditionalOnMissingBean
ZipkinLoadBalancer loadBalancerClientZipkinLoadBalancer( ZipkinProperties zipkinProperties) {
return new LoadBalancerClientZipkinLoadBalancer(this.client, zipkinProperties);
}
}
@Configuration
@ConditionalOnProperty(value = "spring.zipkin.discoveryClientEnabled", havingValue = "false")
static class ZipkinClientNoOpConfiguration {
@Bean
@ConditionalOnMissingBean
ZipkinLoadBalancer noOpLoadBalancer(final ZipkinProperties zipkinProperties) {
return new NoOpZipkinLoadBalancer(zipkinProperties);
}
}
}if I set spring.zipkin.discoveryClientEnabled=false，can’t create noOpLoadBalancer，still is loadBalancerClientZipkinLoadBalancer. Then I modify this code like this, it work
@Configuration
@ConditionalOnProperty(value = "spring.zipkin.discovery-client-enabled", havingValue = "false")