ExecutorBeanPostProcessor creates proxies with null fields values

[novy1234]

Hi,
I found a problem during creation of async executors proxies in ExecutorBeanPostProcessor.
Namely when creating proxies for the executors they are created with null fields inside, which is a bit problematic if you use any delegating executor, e.g. DelegatingSecurityContextSchedulingTaskExecutor.

From what I have seen, CGLib uses no-args constructor if no constructor arguments have been passed, hence the fields have null values

I use Greenwich.SR1 train/release

Can you help me with that?

[marcingrzejszczak]

All CGLIB proxies have null fields. You shouldn't be using those. What is exactly your problem?

[novy1234]

@marcingrzejszczak My problem is that ExecutorBeanPostProcessor creates proxy of DelegatingSecurityContextSchedulingTaskExecutor which during execution forwards call to yet another task executor. It cannot do so, because the delegate field is null

[marcingrzejszczak]

ok, can you create a small sample that replicates this issue? ALso can you check the latest snapshots, cause AFAIR I've added some fixes at some point

[roll57]

Hello,
I have the same issue, I notice the following log when I start my server:

o.s.aop.framework.CglibAopProxy : Unable to proxy interface-implementing method [public final java.util.List org.springframework.security.concurrent.DelegatingSecurityContextExecutorService.invokeAll(java.util.Collection,long,java.util.concurrent.TimeUnit) throws java.lang.InterruptedException] because it is marked as final: Consider using interface-based JDK proxies instead!

In my code I do:
executorService.invokeAll(...)

I tried with an executorService which have an invokeAll method that is not final and it works.

[marcingrzejszczak]

We can't wrap final methods with cglib. Just try no to use them if possible. My request for a sample is still active