Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

Explicitly add dns scheme to grpc channel addresses #2085

Merged
meltsufin merged 2 commits into from
Dec 17, 2019
Merged

Explicitly add dns scheme to grpc channel addresses #2085

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9c75e7
Explicitly add dns scheme to grpc channel addresses
ST-DDT Dec 17, 2019
29845c8
Configure dns scheme at more places
ST-DDT Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../org/springframework/cloud/gcp/autoconfigure/trace/StackdriverTraceAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public ExecutorProvider traceExecutorProvider(@Qualifier("traceSenderThreadPool"
@Bean(destroyMethod = "shutdownNow")
@ConditionalOnMissingBean(name = "stackdriverSenderChannel")
public ManagedChannel stackdriverSenderChannel() {
return ManagedChannelBuilder.forTarget("cloudtrace.googleapis.com")
return ManagedChannelBuilder.forTarget("dns:///cloudtrace.googleapis.com")
.userAgent(this.headerProvider.getUserAgent())
.build();
}
Expand Down
2 changes: 1 addition & 1 deletion .../spring-cloud-gcp-trace-sample/src/test/java/com/example/TraceSampleApplicationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public void setupTraceClient() throws IOException {
.getService();

ManagedChannel channel = ManagedChannelBuilder
.forTarget("cloudtrace.googleapis.com")
.forTarget("dns:///cloudtrace.googleapis.com")
.build();

this.traceServiceStub = TraceServiceGrpc.newBlockingStub(channel)
Expand Down