Skip to content

Conversation

@erikbern
Copy link
Collaborator

This might fix it, @jlmelville wdyt?

@jlmelville
Copy link

Thanks for attempting this so quickly @erikbern. This passes the GCC-UBSAN check on Rhub, but it's hard to be certain of the fix because due to the stochastic nature of the original problem.

@erikbern
Copy link
Collaborator Author

cool. i'll try to address the failing travis build in the near future

@jayvdb
Copy link

jayvdb commented Feb 7, 2021

note this causes segfaults in hamming_index_test.py::HammingIndexTest::test_many_vectors

@erikbern
Copy link
Collaborator Author

erikbern commented Feb 8, 2021

i completely forgot about this PR, will revisit shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants