Validate keys before persisting items in Azure CosmosDB key-value store #3054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tores Signed-off-by: Thorsten Hans <[email protected]>
lann
approved these changes
Mar 21, 2025
kate-goldenring
approved these changes
Mar 21, 2025
itowlson
reviewed
Mar 23, 2025
Merged
Co-authored-by: itowlson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the key-value store implementation for Azure CosmosDB only.
When calling
set, the specifiedkeyis validated according to the Azure SDK documentation (https://learn.microsoft.com/en-us/dotnet/api/microsoft.azure.documents.resource.id?view=azure-dotnet#remarks).If the key contains an invalid char, the operation is terminated early and a corresponding error is returned.
cargo buildcargo fmtcargo clippymake lintmake test