Work around hyper graceful shutdown bug #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Fixes #73. Knew there was something. |
Collaborator
Author
|
Note that although the server shutdown is not "graceful" in this case, the program shutdown still is - and that is what we need to clean up the temp directories. |
radu-matei
approved these changes
Mar 24, 2022
Member
radu-matei
left a comment
radu-matei
left a comment
There was a problem hiding this comment.
Manually tested on a Mac, this seems to work!
Wow, this was SO annoying, thank you for finding the solution for it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IT WORKS ON WSL AND NOW I AM GOING TO HAVE A GLASS OF WINE