Bump github.com/stretchr/testify from 1.10.0 to 1.11.1 #6270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.10.0 to 1.11.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.10.0...v1.11.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-version: 1.11.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
dependabot
bot
requested review from
MarcosDY,
amartinezfayo,
evan2645,
rturner3 and
sorindumitru
as code owners
dependabot
bot
added
dependencies
A couple tests are using `assert.Equal()` inside a `require.Eventually()`. `assert.Equal()` will cause the test to fail if the assertion is not met. This conflicts with the intention of retrying the equality check in the test. These tests started failing due to a new behavior in `github.com/stretchr/testify` v1.11.0 that started executing the function passed to `require.Eventually()`/`assert.Eventually()` without any initial delay: stretchr/testify#1427 The tests were previously passing by chance due to the timing of how long `github.com/stretchr/testify` was waiting to try the function in `Eventually()` for the first time. Signed-off-by: Ryan Turner <[email protected]>
amartinezfayo
previously approved these changes
Aug 26, 2025
Contributor
Author
|
A newer version of github.com/stretchr/testify exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Signed-off-by: Ryan Turner <[email protected]>
Signed-off-by: Ryan Turner <[email protected]>
rturner3
changed the title
| waitForInformerWatcher(t, test.webhookClient.watcherStarted) | ||
| webhook := newMutatingWebhook(t, test.webhookClient.Interface, "spire-webhook", "") | ||
|
|
||
| require.Eventually(t, func() bool { |
Collaborator
There was a problem hiding this comment.
There's also the option of using EventuallyWithT. It has an assert.CollectT parameter that I think is usable with require.X.
Signed-off-by: Ryan Turner <[email protected]>
Signed-off-by: Ryan Turner <[email protected]>
Signed-off-by: Ryan Turner <[email protected]>
Collaborator
|
Looks like in |
Signed-off-by: Ryan Turner <[email protected]>
sorindumitru
approved these changes
Sep 2, 2025
dependabot
bot
deleted the
dependabot/go_modules/github.com/stretchr/testify-1.11.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/stretchr/testify from 1.10.0 to 1.11.1.
Release notes
Sourced from github.com/stretchr/testify's releases.
... (truncated)
Commits
b7801fbMerge pull request #1778 from stretchr/dependabot/github_actions/actions/chec...69831f3build(deps): bump actions/checkout from 4 to 5a53be35Improve captureTestingT helperaafb604mock: improve formatting of error message7218e03improve error msg929a212Merge pull request #1758 from stretchr/dolmen/suite-faster-method-filteringbc7459esuite: faster filtering of methods (-testify.m)7d37b5csuite: refactor methodFilterc58bc90Merge pull request #1764 from stretchr/dolmen/suite-refactor-stats-for-readab...87101a6suite.Run: refactor handling of statsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)