-
Notifications
You must be signed in to change notification settings - Fork 3
add pluginReport struct as runtime.object for apiserver #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pluginReport struct as runtime.object for apiserver #358
Conversation
Codecov Report
@@ Coverage Diff @@
## main #358 +/- ##
==========================================
- Coverage 41.61% 40.77% -0.84%
==========================================
Files 8 8
Lines 495 488 -7
==========================================
- Hits 206 199 -7
Misses 285 285
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Icarus9913 <[email protected]>
Signed-off-by: Icarus9913 <[email protected]>
Signed-off-by: Icarus9913 <[email protected]>
Signed-off-by: Icarus9913 <[email protected]>
charts/templates/pvc.yaml
Outdated
| {{- end }} | ||
| {{- end }} No newline at end of file | ||
| {{- end }} | ||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
多余
charts/templates/apiserver.yaml
Outdated
| --- | ||
| {{- if .Values.spiderdoctorApiserver.enable}} | ||
| apiVersion: apps/v1 | ||
| kind: Deployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? 删除了
|
|
||
| // ------------ | ||
| rootLogger.Info("finish initialization") | ||
| rootLogger.Info("finish spiderdoctor-controller initialization") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to end ?
pkg/apiserver/cmd/apiserver/main.go
Outdated
| @@ -0,0 +1,23 @@ | |||
| package main | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
文件删除了 ?
| {{- include "tplvalues.render" ( dict "value" .Values.global.commonAnnotations "context" $ ) | nindent 4 }} | ||
| {{- end }} | ||
| spec: | ||
| insecureSkipTLSVerify: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//TODO
charts/values.yaml
Outdated
| name: "spiderdoctor-apiserver" | ||
|
|
||
| ## @param spiderdoctorApiserver.apiServiceName the spiderdoctorApiserver APIService name | ||
| apiServiceName: "v1beta1.system.spiderdoctor.spidernet.io" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REMOVE
pkg/apiserver/server.go
Outdated
| func NewCommandStartSpiderDoctorServer(stopCh <-chan struct{}) (*cobra.Command, error) { | ||
| options := NewSpiderDoctorServerOptions() | ||
|
|
||
| cmd := &cobra.Command{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cobra
pkg/apiserver/server.go
Outdated
| options.RecommendedOptions.AddFlags(flags) | ||
| utilfeature.DefaultMutableFeatureGate.AddFlag(flags) | ||
|
|
||
| flags.StringVar(&options.ConfigPath, "config-path", "", "configmap path") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
Signed-off-by: Icarus9913 <[email protected]>
I create a new pluginReport struct to make it fit runtime.object rules for apiserver usage
Signed-off-by: Icarus9913 [email protected]