Skip to content

Conversation

@Icarus9913
Copy link
Contributor

I create a new pluginReport struct to make it fit runtime.object rules for apiserver usage

Signed-off-by: Icarus9913 [email protected]

@Icarus9913 Icarus9913 requested a review from weizhoublue as a code owner May 24, 2023 03:15
@Icarus9913 Icarus9913 added the release/feature feature pr recoded in new release label May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #358 (d4ce48a) into main (4ea3f54) will decrease coverage by 0.84%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   41.61%   40.77%   -0.84%     
==========================================
  Files           8        8              
  Lines         495      488       -7     
==========================================
- Hits          206      199       -7     
  Misses        285      285              
  Partials        4        4              
Flag Coverage Δ
unittests 40.77% <100.00%> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/loadRequest/loadDns/dns.go 91.89% <100.00%> (ø)
pkg/loadRequest/loadDns/dns_requester.go 97.34% <100.00%> (-0.16%) ⬇️

Signed-off-by: Icarus9913 <[email protected]>
Signed-off-by: Icarus9913 <[email protected]>
Signed-off-by: Icarus9913 <[email protected]>
{{- end }}
{{- end }} No newline at end of file
{{- end }}
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多余

---
{{- if .Values.spiderdoctorApiserver.enable}}
apiVersion: apps/v1
kind: Deployment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? 删除了


// ------------
rootLogger.Info("finish initialization")
rootLogger.Info("finish spiderdoctor-controller initialization")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to end ?

@@ -0,0 +1,23 @@
package main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件删除了 ?

{{- include "tplvalues.render" ( dict "value" .Values.global.commonAnnotations "context" $ ) | nindent 4 }}
{{- end }}
spec:
insecureSkipTLSVerify: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//TODO

name: "spiderdoctor-apiserver"

## @param spiderdoctorApiserver.apiServiceName the spiderdoctorApiserver APIService name
apiServiceName: "v1beta1.system.spiderdoctor.spidernet.io"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REMOVE

func NewCommandStartSpiderDoctorServer(stopCh <-chan struct{}) (*cobra.Command, error) {
options := NewSpiderDoctorServerOptions()

cmd := &cobra.Command{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cobra

options.RecommendedOptions.AddFlags(flags)
utilfeature.DefaultMutableFeatureGate.AddFlag(flags)

flags.StringVar(&options.ConfigPath, "config-path", "", "configmap path")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@weizhoublue weizhoublue merged commit 4ab763f into spidernet-io:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/feature feature pr recoded in new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants