Skip to content

Conversation

@Sevenannn
Copy link

Rationale for this change

What changes are included in this PR?

  • Use Vec to store filter and preserve ordering
  • Check if filter exist in Vec when adding filter

Are these changes tested?

Yes

@Sevenannn Sevenannn marked this pull request as ready for review November 5, 2024 18:36
@Sevenannn Sevenannn self-assigned this Nov 5, 2024
@sgrebnov sgrebnov merged commit 28efc88 into spiceai-42 Nov 5, 2024
@sgrebnov sgrebnov deleted the qianqian/fix-filter branch November 5, 2024 20:30
sgrebnov pushed a commit that referenced this pull request Nov 29, 2024
…pache#13422)

* Eliminate duplicated filter within (filter(TableScan)) plan (#51)

* Eliminate duplicated filter within (filter(TableScan)) plan

* Updates

* fix

* add test

* fix

* Preserve the filter order when eliminating duplicated filter #56

* Use IndexSet instead of Vec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants