Support rebuilds, add pre-commit#19
Conversation
|
@chrisjsewell I'm aiming to push a release tomorrow night around 10:30PM EST. |
Cool cheers If you don't mind I added a pre-commit config to the repo, and run the black CI via that (there's some other commented out checks you might consider adding) |
|
I'm also running the tests via tox. |
TheTripleV
left a comment
There was a problem hiding this comment.
Could you add a dirhtml test case similar to the html test case you already added?
|
Sure! I'm open to the tox file. |
Done 👍 I figured out something a bit annoying; sphinx doesn't clean the build folder in-between each test. |
|
Yeah I just noticed that while working on the other open pr. I'll make an issue as we should clean the build folder before every test. |
Yeh I guess just make a new fixture: @pytest.fixture()
def app_clean(app):
if Path(app.outdir).exists():
shutil.rmtree(Path(app.outdir))
yield app(or clean after) |
TheTripleV
left a comment
There was a problem hiding this comment.
The dirhtml test is using the html builder.
Co-authored-by: Vasista Vovveti <[email protected]>
Ooops my bad 🤦 |
|
LGTM. This will get merged in tomorrow. |
|
Brilliant, thanks for the great extension 😄 |
* Support rebuilds * Add pre-commit and CI * Add dirhtml test * Apply suggestions from code review Co-authored-by: Vasista Vovveti <[email protected]> Co-authored-by: Vasista Vovveti <[email protected]>
Fixes #18