Skip to content

Implement auto redirect#10

Merged
Daltz333 merged 1 commit intosphinx-doc:masterfrom
Daltz333:auto-file
Aug 30, 2020
Merged

Implement auto redirect#10
Daltz333 merged 1 commit intosphinx-doc:masterfrom
Daltz333:auto-file

Conversation

@Daltz333
Copy link
Collaborator

@Daltz333 Daltz333 commented Aug 25, 2020

TODO

  • When writing to file, always use forward slashes
  • When writing to file, always surround in quotes
  • Write tests

@Daltz333 Daltz333 marked this pull request as draft August 25, 2020 05:46
@Daltz333 Daltz333 requested a review from TheTripleV August 25, 2020 17:37
@Daltz333 Daltz333 marked this pull request as ready for review August 25, 2020 17:38
@TheTripleV
Copy link
Collaborator

My PR to this branch addresses the comments to rediraffe.py.

A few upkeep things:

  1. Could you add a few more tests, covering more complex setups & rediraffe_auto_redirect_perc? The one test case was passing but was relying on an ambiguous variable.
  2. Can you further separate the checkdiff and writediff tests? (change test names or wrap in separate classes / files). I had created the tests when there was only 1 builder.

@TheTripleV
Copy link
Collaborator

Depends on #9. This PR wraps filenames in quotes.

@TheTripleV
Copy link
Collaborator

Closes #4.

@Daltz333 Daltz333 requested a review from TheTripleV August 29, 2020 14:49
@Daltz333 Daltz333 force-pushed the auto-file branch 6 times, most recently from ec79d23 to 6b43654 Compare August 30, 2020 03:15
@Daltz333 Daltz333 merged commit 4026ec2 into sphinx-doc:master Aug 30, 2020
TheTripleV added a commit to TheTripleV/sphinxext-rediraffe-1 that referenced this pull request Sep 30, 2020
Co-authored-by: TheTripleV <[email protected]>

Co-authored-by: TheTripleV <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants