Refactor social card to enable customizing generation#146
Open
ewjoachim wants to merge 5 commits intosphinx-doc:masterfrom
Open
Refactor social card to enable customizing generation#146ewjoachim wants to merge 5 commits intosphinx-doc:masterfrom
ewjoachim wants to merge 5 commits intosphinx-doc:masterfrom
Conversation
3c9d5b0 to
d22fe53
Compare
d22fe53 to
4834cdc
Compare
47cd3a9 to
b488092
Compare
b488092 to
86216e1
Compare
Author
|
I believe this PR is ready ! It has tests, and docs, I'm using the corresponding code in another repo with success, I'm satisfied with the state of the code. The only thing is the split into smaller commits which is hard on those kinds of refactors, but if it's valuable to you, let me know. |
Author
|
Is there anything I can do to help merge this ? Would it help if I try to make smaller commits ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #145
So... I ended up involuntarily refactoring a large part of social card, here's what happened:
I think I'm also solving a few bugs (some text colors that should have been customizable were not, and an advertised
text_colorparameter was likely not working).I'm sorry about the large commit, but I really didn't know how to split it in a way that makes sense.