Don't dereference symlinks when copying files#20
Closed
brechtm wants to merge 1 commit intosphinx-contrib:masterfrom
Closed
Don't dereference symlinks when copying files#20brechtm wants to merge 1 commit intosphinx-contrib:masterfrom
brechtm wants to merge 1 commit intosphinx-contrib:masterfrom
Conversation
This prevents FileNotFoundError exceptions on broken symlinks. Symlinks in a repository should be relative anyway, so there is no advantage to dereferencing them.
1 similar comment
Collaborator
|
That keyword arg doesn't exist for .copy() in Python 2.7. |
Robpol86
added a commit
that referenced
this pull request
Aug 22, 2016
Skipping broken symlinks, but not all symlinks. Reported in #20
Collaborator
|
Fixed in 8dbff4e. Thanks for reporting this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents FileNotFoundError exceptions on broken symlinks.
Symlinks in a repository should be relative anyway, so there is no
advantage to dereferencing them.