Skip to content

Conversation

@apelisse
Copy link

@apelisse apelisse commented Aug 2, 2016

Currently, if you don't set any value for a StringSliceVar, it will
end-up failing with an EOF error. It fails because the CSV parser for
the value can't read anything.

Special case when the string is empty to return an empty list.

cc @eparis @foxish

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@apelisse
Copy link
Author

apelisse commented Aug 2, 2016

I re-pushed the commit with a test.

@eparis
Copy link
Collaborator

eparis commented Aug 2, 2016

I would merge, but jenkins is showing me a blank page... will check back in a bit to see if jenkins is working...

Currently, if you don't set any value for a StringSliceVar, it will
end-up failing with an EOF error. It fails because the CSV parser for
the value can't read anything.

Special case when the string is empty to return an empty list.
@apelisse apelisse force-pushed the fix-empty-string-slice branch from 5b9322c to 1ceb032 Compare August 3, 2016 15:47
@eparis eparis closed this Aug 3, 2016
@eparis eparis reopened this Aug 3, 2016
@eparis eparis merged commit f676131 into spf13:master Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants