Skip to content

Fix panic when parsing unknown flag followed by empty argument #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eparis merged 1 commit into from
Aug 31, 2018
Merged

Fix panic when parsing unknown flag followed by empty argument #173

eparis merged 1 commit into from
Aug 31, 2018

Conversation

@shomron
Copy link

@shomron shomron commented Jun 29, 2018

Reproducing the panic:

fset := pflag.NewFlagSet("", pflag.ContinueOnError)
fset.ParseErrorsWhitelist.UnknownFlags = true
fset.Parse([]string{"--unknown", ""})

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

This was referenced Jun 29, 2018
Closed
Open
@shomron
Copy link
Author

shomron commented Aug 29, 2018

Ping. Anyone had a chance to look at this?

shomron added a commit to shomron/cobra that referenced this pull request Aug 29, 2018
@shomron
Use github.com/shomron/pflag fork until spf13/pflag/pull/173 is merged
5d46736 
Signed-off-by: Oren Shomron <[email protected]>
shomron added a commit to shomron/cobra that referenced this pull request Aug 29, 2018
@shomron
Use github.com/shomron/pflag fork until spf13/pflag/pull/173 is merged
30732d3 
Signed-off-by: Oren Shomron <[email protected]>
thaJeztah
thaJeztah approved these changes Aug 31, 2018
View reviewed changes
Copy link

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ping @eparis @spf13 ptal

@eparis eparis merged commit 298182f into spf13:master Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thaJeztah thaJeztah thaJeztah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shomron @CLAassistant @thaJeztah @eparis