Skip to content

add line numbers#2133

Open
AntekOlszewski wants to merge 3 commits into
spectreconsole:mainfrom
AntekOlszewski:line-numbers-renderable
Open

add line numbers#2133
AntekOlszewski wants to merge 3 commits into
spectreconsole:mainfrom
AntekOlszewski:line-numbers-renderable

Conversation

@AntekOlszewski

Copy link
Copy Markdown
Contributor

Fixes #2088

  • I have read the Contribution Guidelines
  • I have checked that there isn't already another pull request that solves the above issue
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors

Changes

Added LineNumber IRenderable, i need a tip how to properly implement Measurement


Please upvote 👍 this pull request if you are interested in it.

@patriksvensson patriksvensson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

This is new functionality and also requires comprehensive tests like other widgets.

Comment thread src/Spectre.Console/Widgets/LineNumbers.cs Outdated
Comment thread src/Spectre.Console/Widgets/LineNumbers.cs
Comment thread src/Spectre.Console/Widgets/LineNumbers.cs
@AntekOlszewski AntekOlszewski marked this pull request as draft June 6, 2026 07:34
@AntekOlszewski AntekOlszewski marked this pull request as ready for review June 6, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add built-in line numbers support for JsonText

2 participants