Skip to content

Trimming of TestConsole output by CommandAppTester is user configurable. #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

Trimming of TestConsole output by CommandAppTester is user configurable. #1739

merged 1 commit into from
Jan 21, 2025

Conversation

@FrankRay78
Copy link
Contributor

@FrankRay78 FrankRay78 commented Jan 21, 2025

fixes #1738. CommandAppTester is trimming TestConsole output, requiring expected outputs to be manually adjusted

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

Trimming of TestConsole output by CommandAppTester is user configurable.

CommandAppTester now accepts a CommandAppTesterSettings class, containing the TrimConsoleOutput property.

TrimConsoleOutput defaults to true, preserving existing behaviour and ensuring the change is backward compatible.

Please upvote 👍 this pull request if you are interested in it.

@FrankRay78 FrankRay78 self-assigned this Jan 21, 2025
@FrankRay78 FrankRay78 added the area-Testing-Framework Spectre.Console testing framework for developers. label Jan 21, 2025
@FrankRay78 FrankRay78 added this to the 0.50 milestone Jan 21, 2025
@FrankRay78 FrankRay78 mentioned this pull request Jan 21, 2025
Closed
@patriksvensson patriksvensson merged commit f704f2a into spectreconsole:main Jan 21, 2025
3 checks passed
@FrankRay78
Copy link
Contributor Author

FrankRay78 commented Jan 21, 2025

Many thanks @patriksvensson

@FrankRay78 FrankRay78 deleted the 1738-CommandAppTester-is-trimming-TestConsole-output branch February 10, 2025 21:59
This was referenced Jul 22, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 30, 2025
Closed
Closed
Open
Closed
Merged
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Aug 11, 2025
Closed
This was referenced Oct 17, 2025
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
This was referenced Oct 27, 2025
Closed
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Closed
Closed
Closed
Closed
This was referenced Nov 10, 2025
Open
Open
Open
Open
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patriksvensson patriksvensson patriksvensson approved these changes

Assignees

@FrankRay78 FrankRay78

Labels

area-Testing-Framework Spectre.Console testing framework for developers.

Projects

Spectre Console
Status: PR 📬

Milestone

0.50

Development

Successfully merging this pull request may close these issues.

CommandAppTester is trimming TestConsole output, requiring expected outputs to be manually adjusted

2 participants

@FrankRay78 @patriksvensson