Skip to content

Conversation

@FrankRay78
Copy link
Contributor

fixes #981

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

ProgressTask.GetPercentage() returns 100 when max value is 0.


Please upvote 👍 this pull request if you are interested in it.

Setting_Max_Value_To_Zero_Should_Make_Percentage_OneHundred();
@FrankRay78 FrankRay78 added this to the 0.51 milestone Nov 22, 2024
@FrankRay78 FrankRay78 added the bug Something isn't working label Nov 22, 2024
@FrankRay78 FrankRay78 self-assigned this Nov 22, 2024
@FrankRay78 FrankRay78 requested a review from a team November 22, 2024 10:57
@patriksvensson patriksvensson merged commit 4515d89 into spectreconsole:main Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: PR 📬

Development

Successfully merging this pull request may close these issues.

ProgressTask.GetPercentage() throws a division by 0 exception when MaxValue is 0

2 participants