Fix help render when NO_COLOR is specified #1584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, running `--help` with `NO_COLOR` set, results in formatting still being applied via markup to the options and default values. This complements the previous fix for spectreconsole#211 for that scenario and is related to spectreconsole#1408. Fixes spectreconsole#1583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running
--helpwithNO_COLORset, results in formatting still being applied via markup to the options and default values.This complements the previous fix for #211 for that scenario and is related to #1408.
Fixes #1583
fixes #
Changes
Please upvote 👍 this pull request if you are interested in it.