refactor(route/caniuse): merge respec-caniuse-route to main#146
Merged
sidvishnoi merged 2 commits intomainfrom Feb 18, 2021
Merged
refactor(route/caniuse): merge respec-caniuse-route to main#146sidvishnoi merged 2 commits intomainfrom
sidvishnoi merged 2 commits intomainfrom
Conversation
38e5c4c to
39ea61e
Compare
39ea61e to
fcdc059
Compare
This was referenced Feb 18, 2021
This was referenced Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
routes/caniuse/libas the destination.shutility, which respec-caniuse-route/scraper and others can use consistently. I've used this it in spec-prod, so it's "well tested".routes/caniuse/lib/index.tsmakes use ofucontentinstead of manipulating template strings. i.e.routes/caniuse/lib/scraper.tsdoes shallow git clone/pull to save space on server (from 125MB to 25MB). i.e.routes/caniuse/lib/index.tsusesutils/mem-cacheinstead of its own cache.