fix(validation): fix error generation in expression validator #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhbr
force-pushed
the
maxhbr/fix764
branch
5 times, most recently
from
432d9e9 to
20fbe55
Compare
Signed-off-by: Maximilian Huber <[email protected]>
maxhbr
force-pushed
the
maxhbr/fix764
branch
from
20fbe55 to
79d744f
Compare
bmihaila-bd
approved these changes
Sep 28, 2023
armintaenzertng
approved these changes
Sep 28, 2023
| "Error parsing LicenseExpression: \"LGPL-2.1, GPL-2.0, GPL-3.0\": Invalid license key: the valid characters are: letters and numbers, underscore, dot, colon or hyphen signs and spaces: 'LGPL-2.1, GPL-2.0, GPL-3.0'" # noqa: E501 | ||
| ], | ||
| ), | ||
| ("Apache License (2.0)", ['Error parsing LicenseExpression: "Apache License (2.0)"']), |
Collaborator
There was a problem hiding this comment.
Not too helpful, but if the license-expression library does not return any message, we can't do anything about here, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #764