add encoding parameter for parsing files
#756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhbr
previously approved these changes
Sep 7, 2023
Member
maxhbr
left a comment
maxhbr
left a comment
There was a problem hiding this comment.
Code looks good, thanks for that contribution.
chrisdecker1201
changed the title
encoding parameter for parseing filesencoding parameter for parsing files
chrisdecker1201
force-pushed
the
feature/parse_file_encoding
branch
from
5a541b1 to
8fb5d04
Compare
armintaenzertng
requested changes
Sep 8, 2023
Signed-off-by: Christian Decker <[email protected]>
chrisdecker1201
force-pushed
the
feature/parse_file_encoding
branch
from
8fb5d04 to
45d3fa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#755