[issue-721] update Actor regex and parsing #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Armin Tänzer <[email protected]>
armintaenzertng
force-pushed
the
updateActorRegex
branch
from
ddf70ce to
8e1cd65
Compare
fholger
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new logic follows this rule:
First, split off the
ActorTypepart.Then, if the last character in the string is a closing bracket and there exists a corresponding opening bracket, match everything between these two brackets as
emailand the rest of the string asname.If the the last character is not a closing bracket, match the whole string as
name.I also added some more tests for this.
fixes #721