make example files valid #607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meret Behrens <[email protected]>
armintaenzertng
approved these changes
Apr 24, 2023
Collaborator
armintaenzertng
left a comment
armintaenzertng
left a comment
There was a problem hiding this comment.
It certainly does not make sense to define "purl" in the local namespace.
We should also open a PR against the spec.
Collaborator
Author
No need to open a PR against the spec, the files in the spec don't have a namespace at the fields. Sorry, if I wasn't clear on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that these two example files are marked as invalid. The changed files align with the examples given in the spdx-spec repo. As far as I understand the spec we only add the documents namespace to
referenceTypeinRDFformat, not in any other. So I think the examples were simply incorrect and there is no need to adapt the code to accept these kind ofreferenceType.