Skip to content

Conversation

@armintaenzertng
Copy link
Collaborator

I had to exclude the __init__.py from isort and flake8 because the order of the imports matters in that case.

part of #593

Copy link
Collaborator

@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is real improvement concerning readability. I was wondering if we might want to use this for other classes outside of spdx_tools.spdx.model, for example the parser class in spdx_tools.spdx.parser.jsonlikedict, what do you think?

@armintaenzertng
Copy link
Collaborator Author

I also think that this approach can be applied to other packages as well, but it probably has the most impact for the model package, as that is the one that will be most widely used by users, I imagine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants