[issue_508] add methods to remove duplicated items from list properties #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armintaenzertng
previously approved these changes
Apr 18, 2023
Collaborator
armintaenzertng
left a comment
armintaenzertng
left a comment
There was a problem hiding this comment.
Thanks, only a minor remark.
src/spdx/document_utils.py
Outdated
| list_without_duplicates = [] | ||
| for element in list_with_potential_duplicates: | ||
| if element not in list_without_duplicates: | ||
| list_without_duplicates.append(deepcopy(element)) |
Collaborator
There was a problem hiding this comment.
I don't think we need to deepcopy the element here as it is already a copy of the original document.
Signed-off-by: Meret Behrens <[email protected]>
meretp
force-pushed
the
issue_508_dont_write_duplicates
branch
from
87c3578 to
ea15edc
Compare
armintaenzertng
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #508