[issue_589] fix json parser: process fields that can be "NOASSERTION"… #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or "NONE" correctly Signed-off-by: Meret Behrens <[email protected]>
armintaenzertng
approved these changes
Apr 18, 2023
Collaborator
armintaenzertng
left a comment
armintaenzertng
left a comment
There was a problem hiding this comment.
Good catch! :)
I have a small remark that I don't feel very strongly about.
Comment on lines
+21
to
+58
| "homepage, expected_homepage, download_location, expected_download_location, " | ||
| "copyright_text, expected_copyright_text, originator, expected_originator, supplier, expected_supplier", | ||
| [ | ||
| ( | ||
| "http://ftp.gnu.org/gnu/glibc", | ||
| "http://ftp.gnu.org/gnu/glibc", | ||
| "NOASSERTION", | ||
| SpdxNoAssertion(), | ||
| "NONE", | ||
| SpdxNone(), | ||
| "Organization: ExampleCodeInspect ([email protected])", | ||
| Actor(ActorType.ORGANIZATION, "ExampleCodeInspect", "[email protected]"), | ||
| "NOASSERTION", | ||
| SpdxNoAssertion(), | ||
| ), | ||
| ( | ||
| "NOASSERTION", | ||
| SpdxNoAssertion(), | ||
| "NONE", | ||
| SpdxNone(), | ||
| "Copyright 2008-2010 John Smith", | ||
| "Copyright 2008-2010 John Smith", | ||
| None, | ||
| None, | ||
| None, | ||
| None, | ||
| ), | ||
| ( | ||
| "NONE", | ||
| SpdxNone(), | ||
| "http://ftp.gnu.org/gnu/glibc/glibc-ports-2.15.tar.gz", | ||
| "http://ftp.gnu.org/gnu/glibc/glibc-ports-2.15.tar.gz", | ||
| "NOASSERTION", | ||
| SpdxNoAssertion(), | ||
| "NOASSERTION", | ||
| SpdxNoAssertion(), | ||
| "Person: Jane Doe ([email protected])", | ||
| Actor(ActorType.PERSON, "Jane Doe", "[email protected]"), |
Collaborator
There was a problem hiding this comment.
This is kind of hard to comprehend due to the scrambling of normal, none and no assertion cases. I get that this might make the test cases more diverse, but I don't think it is really worth it compared to just having test cases where all values are normal values or None/NONE etc.
Collaborator
Author
There was a problem hiding this comment.
Yes, my intention was to make the test cases more diverse. I think both options doesn't really make a difference and as they are also just test cases I would stick to the current implementation and merge it like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… or "NONE" correctly
The issue is only related to the homepage field, while working on the fix, I noticed that the issue also applies to other fields.
fixes #589