[issue-532] Add linter action #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
meretp
force-pushed
the
add-linter-action
branch
from
19d25cc to
b3f08f2
Compare
Closed
armintaenzertng
approved these changes
Mar 30, 2023
Collaborator
armintaenzertng
left a comment
armintaenzertng
left a comment
There was a problem hiding this comment.
Thanks, I just tried it and it worked mostly except for very long strings. Is this something that has to be done manually?
Collaborator
Author
|
Unfortunately yes. With a quick research I found that there are some tools that could do this automatically but as this would probably need more work (setting up the tool and so on), I decided to do it manually. I would assume that this is a justifiable effort in the future. |
Merged
Collaborator
|
A fix of this is part of #546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub Action to check the code style with
black,isortandflake8. The new GitHub Action is expected to fail as the current code doesn't comply with these linters. A second PR will follow to fix this.