Skip to content

Conversation

@maxhbr
Copy link
Member

@maxhbr maxhbr commented Mar 29, 2023

This is not to be merged, but instead its HEAD 3f2619c is the relevant merge commit should directly be pushed to main.

@goneall : can you open the branch protection rules for a short window so that I can push or otherwise you can push it (if admins can ignore branch protection rules in this repo)?

Nicolaus Weidner and others added 30 commits January 3, 2023 10:25
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
meretp and others added 27 commits March 9, 2023 12:12
[review] fix parsing of external document ref
[review] use only one dictionary
[review] return if multiple values for snippet range found

Signed-off-by: Meret Behrens <[email protected]>
…ression, SpdxNone or SpdxNoAssertion

Signed-off-by: Meret Behrens <[email protected]>
… cases for LicenseInfoFromFiles, LicenseInfoInFile and LicenseInfoInSnippet

Signed-off-by: Meret Behrens <[email protected]>
…y inferred from the creation_info

Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Gary O'Neall <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
This merges the long awaited refactoring. The "old" 0.7.1 release is
still on its own branch and can receive bugfixes there.

Signed-off-by: Maximilian Huber <[email protected]>
@maxhbr maxhbr requested a review from goneall March 29, 2023 13:50
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review all 365 files, but the structure looks good and I agree we should move the refactored branch into main.

@maxhbr maxhbr merged commit 3f2619c into main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants