[issue-402] add validation option to tag-value writer #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meret Behrens <[email protected]>
| def write_document_to_file(document: Document, file_name: str, validate: bool = True): | ||
| if validate: | ||
| validation_messages: List[ValidationMessage] = validate_full_spdx_document(document, | ||
| document.creation_info.spdx_version) |
Collaborator
There was a problem hiding this comment.
You don't need to specify the version, it will be automatically inferred from the creation_info
Collaborator
Author
There was a problem hiding this comment.
Alright, I deleted the argument in the other writer functions as well.
…y inferred from the creation_info Signed-off-by: Meret Behrens <[email protected]>
armintaenzertng
approved these changes
Mar 28, 2023
Collaborator
armintaenzertng
left a comment
armintaenzertng
left a comment
There was a problem hiding this comment.
Thanks, looks good :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading through the migration guideline I came across the line
which lead me to this addition.
part of #402