Clean up examples #482
Merged
Clean up examples #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… schema for json/yaml/xml Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a start to solving #360 I deleted those files which aren't valid according to the spec. Or more precise: json, yaml and xml formats weren't defined in specVersion 2.1, so it does not make sense to keep these examples in the repo. Additionally, I deleted some data in the SBOM file which were added later on, probably to test a feature development but doesn't make sense for the original file. Trying to parse the SBOM file would still cause a ValidationError but as this is a file from specVersion 2.2 and the validation is still an open issue (#463), I think we can leave the example as is in the repo.