Issue 456 add rdf parser #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
…on, yaml, xml and rdf parsing Signed-off-by: Meret Behrens <[email protected]>
meretp
force-pushed
the
issue-456-add-rdf-parser
branch
3 times, most recently
from
f163c45 to
ef61acf
Compare
meretp
force-pushed
the
issue-456-add-rdf-parser
branch
from
158a28a to
e578450
Compare
armintaenzertng
requested changes
Feb 20, 2023
Collaborator
armintaenzertng
left a comment
armintaenzertng
left a comment
There was a problem hiding this comment.
Thanks for the effort! :)
Looks very good to me overall, but I have a few details to go over again.
meretp
force-pushed
the
issue-456-add-rdf-parser
branch
2 times, most recently
from
c99aa82 to
868461b
Compare
armintaenzertng
approved these changes
Feb 21, 2023
Collaborator
armintaenzertng
left a comment
armintaenzertng
left a comment
There was a problem hiding this comment.
Thanks for addressing the issues :)
I have two small remarks left
| parsing_method=str) | ||
| cross_references = [] | ||
| for (_, _, cross_reference_node) in graph.triples((extracted_licensing_info_node, RDFS.seeAlso, None)): | ||
| cross_references.append(cross_reference_node.toPython()) |
Collaborator
There was a problem hiding this comment.
makes sense, let's keep it that way :)
meretp
force-pushed
the
issue-456-add-rdf-parser
branch
from
51bfd7c to
c7860ad
Compare
armintaenzertng
requested changes
Feb 21, 2023
Collaborator
armintaenzertng
left a comment
armintaenzertng
left a comment
There was a problem hiding this comment.
Sorry, but there is still an issue with the range parser...
armintaenzertng
approved these changes
Feb 22, 2023
Collaborator
armintaenzertng
left a comment
armintaenzertng
left a comment
There was a problem hiding this comment.
Well then, off we go! :D
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
…it is used in the parser and writer layer Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
…paces prefix to the short identifier Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
…helper method Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
extract method to apply parsing method or log error, change order of parameters, rename method_to_apply -> parsing_method Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
… as license expression (could be ListedLicense, ExtractedLicensingInfo or simple reference) Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
…tly only supports SPDX 2.3 Signed-off-by: Meret Behrens <[email protected]>
…l helper method, rename argument Signed-off-by: Meret Behrens <[email protected]>
…r json,yaml,xml and rdf parsing Signed-off-by: Meret Behrens <[email protected]>
…, reformat Signed-off-by: Meret Behrens <[email protected]>
…and Python 3.8 Signed-off-by: Meret Behrens <[email protected]>
…nctiveLicenseSet Signed-off-by: Meret Behrens <[email protected]>
…eading/ trailing whitespaces in string values Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
The return value of err.args[0] is a string, so we need to use append to add this string to the list of messages in the logger. Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
…e general helper method Signed-off-by: Meret Behrens <[email protected]>
Signed-off-by: Meret Behrens <[email protected]>
meretp
force-pushed
the
issue-456-add-rdf-parser
branch
from
b34f727 to
1cbe629
Compare
This was referenced Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #456
Signed-off-by: Meret Behrens [email protected]