[issue-386] Finish Package validation #461
Conversation
Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
meretp
left a comment
meretp
left a comment
There was a problem hiding this comment.
Thanks! Two small remarks from my side, not really blocking, so I would approve this as is.
| (PackageVerificationCode("71c4025dd9897b364f3ebbb42c484ff43d00791c", ["/invalid/excluded/file"]), | ||
| 'file name must not be an absolute path starting with "/", but is: /invalid/excluded/file') | ||
| ]) |
There was a problem hiding this comment.
You could add one more testcase with an uppercase checksum as you added this in the vlaidation message.
There was a problem hiding this comment.
ah yes, and I wanted to give checksums the same treatment
| validation_messages.append( | ||
| ValidationMessage( | ||
| f"package must contain no elements if files_analyzed is False, but found {contained_in_package_relationships}", | ||
| f"package must contain no elements if files_analyzed is False, but found {combined_relationships}", |
There was a problem hiding this comment.
Reading this, I was wondering if a package must contain no elements in general or only files? The spec is mostly referring to files and I am not sure, if a package could contain anything other than a file.
There was a problem hiding this comment.
I don't think it can contain anything else than files. This is not explicitly stated by the spec for relationships, so who knows... I would leave it like that for now.
Signed-off-by: Armin Tänzer <[email protected]>
2 participants
fixes #386