[issue-10] use license_expression library for LicenseExpression #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Armin Tänzer <[email protected]>
armintaenzertng
force-pushed
the
licenseExpressions
branch
from
6dae9f4 to
cf244f5
Compare
meretp
requested changes
Jan 27, 2023
Collaborator
meretp
left a comment
meretp
left a comment
There was a problem hiding this comment.
Thanks for fixing this long open issue!
I have found a few minor errors, we should add tests for these.
as they are already caught by append_parsed_field_or_log_error Signed-off-by: Armin Tänzer <[email protected]>
to handle lists of licenses with NONE and NOASSERTION values Signed-off-by: Armin Tänzer <[email protected]>
Signed-off-by: Armin Tänzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
LicenseExpressioninstances can not be evaluated to bool, so statements likeif license_expression:don't work anymore.fixes #10
Signed-off-by: Armin Tänzer [email protected]