feat: add sparkbox logo to previous apprentices component#29
feat: add sparkbox logo to previous apprentices component#29changangus merged 2 commits intomainfrom
Conversation
|
✔️ Deploy Preview for sb-apprentices ready! 🔨 Explore the source changes: ce748f7 🔍 Inspect the deploy log: https://app.netlify.com/sites/sb-apprentices/deploys/61a8dec760363f0007191bc6 😎 Browse the preview: https://deploy-preview-29--sb-apprentices.netlify.app |
c0f8f18 to
b94d4d3
Compare
| .previous-apprentices { | ||
| background: url('../../public/sparkbox-logo.svg') no-repeat; | ||
| background-size: 40rem; | ||
| background-position: 68rem; |
There was a problem hiding this comment.
Nice work Alice, I think we just need to make some adjustments to the background position. The larger the screen gets, the farther to the left the logo moves. At a 4K screen width 3840px, the logo is almost all the way on the left.
We can use calc to position it horizontally from the center, so that it stays in a fixed position regardless of how large the screen gets. I eyeballed these values in the devtools, but we'll probably want to adjust it and get J's feedback.
background-position-x: calc(50% + 38rem);
background-position-y: 16rem;Also, I think we only need to apply the bg image above a particular screen width. J's designs don't appear to show it on smaller screen sizes.
3fff397 to
408ffbd
Compare
|
Thanks for the updates Alice, looks good! We'll get a final approval from J on the placement after this is merged in and included in #31. This is good to merge! |
References FSA21V2-158
…ntices sparkbox logo background
408ffbd to
ce748f7
Compare
References FSA21V2-158
Description
Add sparkbox logo to previous apprentices component.
Spec
Designs: Design
See Story: FSA21V2-158
To Test
npm run test:ci[For an example of good validation instructions, check out Bryan's Bouncy Ball PR.]
Validation
The following has been completed by the developer:
[delete anything irrelevant to this PR]
Browser Testing
[delete if irrelevant to this issue]
Gold Level Browsers
In these browsers, all content is accessible and design matches exactly. In most cases, bugs should be resolved before merge.
macOS
Windows
Mobile
Silver Level Browsers
In these browsers, all content is readable, but design may be inaccurate.
Windows
Mobile
Bronze Level Browsers
In these browsers, our only goal is content readability.
Windows