Skip to content

feat: add previous apprentices component#21

Merged
jonoliver merged 1 commit intomainfrom
feat--add-previous-apprentices
Nov 17, 2021
Merged

feat: add previous apprentices component#21
jonoliver merged 1 commit intomainfrom
feat--add-previous-apprentices

Conversation

@auaruss
Copy link
Copy Markdown
Contributor

@auaruss auaruss commented Nov 16, 2021

Adds the previous apprentices component and related styles and data.

References FSA21V2-149

Description

Adds the previous apprentices component and related styles and data.

Spec

Designs: Design

See Story: FSA21V2-149

To Test

  1. Make sure all PR Checks have passed (Github Actions, Netlify etc).
  2. Pull down all related branches.
  3. Confirm all tests pass: npm run test:ci

[For an example of good validation instructions, check out Bryan's Bouncy Ball PR.]

Validation

The following has been completed by the developer:

  • This PR has visual elements, so it was reviewed by a designer.
  • This PR has code changes, and our linters still pass.
  • This PR affects production code, so it was browser tested (see below).
  • This PR has new code, so new tests were added or updated, and they pass.
  • This PR has copy changes, so copy was proofread and approved.
  • The content of this PR requires documentation, so we added a detailed description of component purpose, requirements, quirks, and instructions for use by designers and developers. Along with accessibility information if pertinent.

Browser Testing

Gold Level Browsers

In these browsers, all content is accessible and design matches exactly. In most cases, bugs should be resolved before merge.

macOS

  • Chrome, current release
  • Firefox, current release
  • Safari, current release

Windows

  • Chrome, current release
  • Firefox, current release

Mobile

  • Chrome on Android 9
  • Safari, current release, on iPhone

Silver Level Browsers

In these browsers, all content is readable, but design may be inaccurate.

Windows

  • Edge, current release

Mobile

  • Android 8 - Chrome on Phone
  • Safari, version before current release, on iPad (including various split screen widths)
  • Chrome on iPhone

Bronze Level Browsers

In these browsers, our only goal is content readability.

Windows

  • IE 11

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 16, 2021

✔️ Deploy Preview for sb-apprentices ready!

🔨 Explore the source changes: 0ec2b0c

🔍 Inspect the deploy log: https://app.netlify.com/sites/sb-apprentices/deploys/619516db88a392000780bd30

😎 Browse the preview: https://deploy-preview-21--sb-apprentices.netlify.app

@auaruss auaruss force-pushed the feat--add-previous-apprentices branch 2 times, most recently from 8a1d2ee to 969036e Compare November 16, 2021 18:27
@auaruss auaruss requested a review from jonoliver November 16, 2021 18:27
@jonoliver
Copy link
Copy Markdown
Member

Nice work Alice! The only thing I would like to fix as part of this PR is a layout tweak to help this section align with the others:
Screen Shot 2021-11-16 at 2 08 00 PM

I think we want to follow a similar style to the other sections, using the variables in _spacing.scss:

  • Container element (in this case article) gets width of $component-width (remove the margin as well)
  • Direct children get max-width of $max-content-width

This will probably leave some minor padding/spacing issues across sections, but I intend to create an overall layout tweak card after we get all sections merged in.

@auaruss auaruss force-pushed the feat--add-previous-apprentices branch 5 times, most recently from c12f0ba to ec3550f Compare November 17, 2021 14:32
Adds the previous apprentices component and related styles and data.

References FSA21V2-149
@auaruss auaruss force-pushed the feat--add-previous-apprentices branch from ec3550f to 0ec2b0c Compare November 17, 2021 14:51
@jonoliver jonoliver merged commit 0ec2b0c into main Nov 17, 2021
@changangus changangus deleted the feat--add-previous-apprentices branch November 24, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants