Conversation
- Move color variables into _colors.scss - Refactor all modues to @use the color partial FSA21V2-135
|
✔️ Deploy Preview for sb-apprentices ready! 🔨 Explore the source changes: 35bc6a1 🔍 Inspect the deploy log: https://app.netlify.com/sites/sb-apprentices/deploys/618153201d9d6000073d510d 😎 Browse the preview: https://deploy-preview-16--sb-apprentices.netlify.app |
catheraaine
approved these changes
Nov 2, 2021
Contributor
catheraaine
left a comment
catheraaine
left a comment
There was a problem hiding this comment.
Nice, I think this is great as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FSA21V2-135
Spec
See Story: FSA21V2-135
To Test
npm run test:ciValidation
The following has been completed by the developer: